Skip to content

[SPARK-2220][SQL] Fixes remaining Hive commands #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liancheng wants to merge 1 commit into from
Closed

[SPARK-2220][SQL] Fixes remaining Hive commands #3038

liancheng wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Oct 31, 2014

This PR adds support for the ADD FILE Hive command, and removes ShellCommand and SourceCommand. The reason is described in this SPARK-2220 comment.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22611 has started for PR 3038 at commit 6db61e0.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22611 has finished for PR 3038 at commit 6db61e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class DFSCommand(kv: Option[(String, Option[String])]) extends Command
    • case class AddFile(path: String) extends LeafNode with Command

@AmplabJenkins
Copy link

AmplabJenkins commented Oct 31, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22611/
Test PASSed.

@marmbrus
Copy link
Contributor

marmbrus commented Oct 31, 2014

Thanks, merged to master. BTW we may want to consider special casing some of these because I believe they are used in the compatibility tests.

@asfgit asfgit closed this in 23468e7 Oct 31, 2014
@liancheng
Copy link
Contributor Author

liancheng commented Oct 31, 2014

@marmbrus Indeed, ddltime.q uses !sleep;.

@liancheng liancheng deleted the hive-commands branch October 31, 2014 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng @SparkQA @AmplabJenkins @marmbrus